msquic icon indicating copy to clipboard operation
msquic copied to clipboard

Additional settings tests and misc changes

Open sm-msft opened this issue 6 months ago • 3 comments

This PR includes the settings related test changes from this original draft PR: https://github.com/microsoft/msquic/pull/5114

Description

  • New Windows user-mode storage API for writing MsQuic test settings
  • Additional settings tests, including tests with stored settings (windows user mode only)
  • Minor build documentation change

Testing

Existing tests + new tests

Documentation

N/A

sm-msft avatar May 30 '25 02:05 sm-msft

I removed changes that update the last member of QUIC_SETTINGS struct in some macros because it was breaking downlevel tests. There seem to be an implicit contract on the size of this struct in the API - does this need any new documentation?

Original context: https://github.com/microsoft/msquic/pull/5114/files/48f6e9fad9ef371d7f8f3ae34bf53fb30dff14f2#r2113830016

sm-msft avatar May 30 '25 02:05 sm-msft

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.00%. Comparing base (cfc5b5e) to head (9111215). Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5132      +/-   ##
==========================================
- Coverage   86.05%   86.00%   -0.06%     
==========================================
  Files          59       59              
  Lines       18048    18027      -21     
==========================================
- Hits        15532    15504      -28     
- Misses       2516     2523       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 30 '25 03:05 codecov[bot]

Discussed Anthony's proposal to move the changes in this PR with https://github.com/microsoft/msquic/pull/5133 and check them in as part of that PR. This is the plan for now.

sm-msft avatar Jun 03 '25 01:06 sm-msft

Changes in this PR have effectively been checked in through https://github.com/microsoft/msquic/pull/5133. Closing this request.

sm-msft avatar Jun 20 '25 23:06 sm-msft