msquic icon indicating copy to clipboard operation
msquic copied to clipboard

added no-asm to the config flag for openssl build

Open gaurav2699 opened this issue 7 months ago • 2 comments

Description

Describe the purpose of and changes within this Pull Request. MSQuic builds fail for amd64 using native compiler. It found that the issue is the assembly implementation of openssl doesnt support control flow guards. Adding no-asm to the config flags fixes the issue.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

Is there any documentation impact for this change?

gaurav2699 avatar May 20 '25 09:05 gaurav2699

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.43%. Comparing base (4ee654a) to head (df13aba). Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5109      +/-   ##
==========================================
- Coverage   86.03%   85.43%   -0.61%     
==========================================
  Files          59       59              
  Lines       18035    18035              
==========================================
- Hits        15517    15408     -109     
- Misses       2518     2627     +109     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 20 '25 10:05 codecov[bot]

As mentioned over IM, we can't take this even if it fixes some internal build issues. No assembly would hurt perf.

nibanks avatar May 22 '25 12:05 nibanks