msquic icon indicating copy to clipboard operation
msquic copied to clipboard

Sleep longer to flush queue for sure

Open ami-GS opened this issue 1 year ago • 1 comments

Description

ConnectionPriority test has been failing frequently at stream start order validation. Increase sleep time for actually flush any remaining operations in processing queue

Testing

Try running CI several times

Documentation

N/A

ami-GS avatar Oct 15 '24 18:10 ami-GS

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.64%. Comparing base (9610803) to head (704c681). Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4615      +/-   ##
==========================================
+ Coverage   85.71%   86.64%   +0.93%     
==========================================
  Files          56       56              
  Lines       17378    17378              
==========================================
+ Hits        14896    15058     +162     
+ Misses       2482     2320     -162     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 15 '24 19:10 codecov[bot]

Fixed only on Linux

ami-GS avatar Nov 30 '24 03:11 ami-GS

Can you add more details/explanation of the core problem and how this fixes it?

nibanks avatar Dec 02 '24 15:12 nibanks

Before actually test starts (issuing StreamStart/StreamSend), implicit connection operations are processed. When any stream operation, which have to be processed later, is inserted to the implicitly processed connection, the expected StreamStart/StreamSend order is messed up. The sleep was to flush all these implicit operations. I thought GetParam can also flush all operation as it is blocking call, but there is still error. I believe that any of implicit operation can be still potentially issued after GetParam call.

ami-GS avatar Dec 02 '24 17:12 ami-GS