msquic icon indicating copy to clipboard operation
msquic copied to clipboard

Misc/WithKeyUpdateArgs1.KeyUpdate/7 failure

Open ami-GS opened this issue 1 year ago • 1 comments

Describe the bug

Found in automation https://github.com/microsoft/msquic/actions/runs/9278086109/job/25528724763?pr=4298

Problem is that the trace says the handshake was finished but the connection is still INVALID_STATE.

[0]07CC.0734::2024/05/29-00:45:32.067547700 [Microsoft-Quic][conn][0x1A065C89EA0] Handshake confirmed (server)

[0]07CC.148C::2024/05/29-00:45:34.319872500 [Microsoft-Quic][test] FAILURE - D:\a\msquic\msquic\src\test\lib\HandshakeTest.cpp:2520 - Server->ForceKeyUpdate() failed, 0x8007139f

https://github.com/microsoft/msquic/blob/2f98992cee5569b44fa42337bb55a91f2b6388d6/src/test/lib/TestConnection.cpp#L234C1-L260C2

Affected OS

  • [X] Windows
  • [ ] Linux
  • [ ] macOS
  • [ ] Other (specify below)

Additional OS information

No response

MsQuic version

main

Steps taken to reproduce bug

no repro locally

Expected behavior

pass

Actual outcome

D:\a\msquic\msquic\src\test\lib\HandshakeTest.cpp(2520): error: Server->ForceKeyUpdate() failed, 0x8007139f

Additional details

No response

ami-GS avatar May 29 '24 04:05 ami-GS

Next step should be

  • Do exponential backoff based sleep. not constant sleep
  • Add indication of handshake complete
  • Add trace here to see all values https://github.com/microsoft/msquic/blob/2f98992cee5569b44fa42337bb55a91f2b6388d6/src/core/connection.c#L6600C1-L6606C10

ami-GS avatar May 29 '24 04:05 ami-GS