msquic
msquic copied to clipboard
Update to OpenSSL v3.3
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.81%. Comparing base (
56ef97b) to head (68529c4). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4274 +/- ##
==========================================
- Coverage 86.00% 85.81% -0.20%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 14925 14892 -33
- Misses 2429 2462 +33
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Seems all the 24.04 builds are failing for some reason
This PR is blocked on linking to the built-in system libcrypto for Ubuntu 24.04. Apparently, the built in version hasn't been updated to a recent enough version to support dynamic linking from libssl v3.3. cc @wfurt
According to GitHub copilot:
The error in the logs indicates multiple "undefined reference" issues related to OpenSSL functions, such as BIO_get_wpoll_descriptor, ossl_time_now, and OSSL_STACK_OF_X509_free, among others. These unresolved references suggest that the linker is unable to find the necessary implementations for these functions, which are likely part of the OpenSSL library.
Potential Fixes:
- Check OpenSSL Library Version: Ensure that the version of OpenSSL being linked against is correct. The functions referenced might belong to a specific version of OpenSSL (e.g., OpenSSL 3.x).
- Library Path Configuration: Verify that the library paths for OpenSSL are correctly set up in the build configuration files (e.g., CMakeLists.txt). Ensure that the linker can locate the correct libraries.
- Update Dependencies: Make sure all dependencies, including OpenSSL, are up to date and properly installed.
- Rebuild OpenSSL: If the custom build of OpenSSL is being used, make sure it is correctly built and all necessary components are included.
These errors are only occurring when we build against the latest v3.3 release of quictls/openssl but statically link against the distro's libcrytpo. It seems there are breaking changes around these APIs for these versions.
cc @wfurt for possible suggestions on a path forward
I'll take a look next week. I assume this fails on the Ubuntu 24?
I'll take a look next week. I assume this fails on the Ubuntu 24?
It fails on 22.04 and 24.04.