msquic icon indicating copy to clipboard operation
msquic copied to clipboard

Support multi config generators on all platforms

Open behda opened this issue 1 year ago • 6 comments

Description

Build Openssl debug and release variants in separate directories to better support multi config generators (like ninja) on all platforms.

Testing

Do any existing tests cover this change? Are new tests needed? Don't think so.

Documentation

Is there any documentation impact for this change? Don't think so.

behda avatar Feb 24 '24 19:02 behda

@behda please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

behda avatar Feb 24 '24 19:02 behda

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.44%. Comparing base (86e08e5) to head (069a289). Report is 54 commits behind head on main.

:exclamation: Current head 069a289 differs from pull request most recent head f3fac5b. Consider uploading reports for the commit f3fac5b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4156       +/-   ##
===========================================
- Coverage   87.38%   65.44%   -21.94%     
===========================================
  Files          56       56               
  Lines       16984    15189     -1795     
===========================================
- Hits        14841     9941     -4900     
- Misses       2143     5248     +3105     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 25 '24 16:02 codecov[bot]

@behda lots of automation failed. Please have a look.

nibanks avatar Feb 26 '24 15:02 nibanks

@nibanks there were problems with Darwin builds and generated empty paths, hopefully fixed now. Can't verify myself as I don't have a Mac with me.

behda avatar Feb 26 '24 17:02 behda

Looks like update to minimal cmake 3.20 is needed. Is it acceptable?

behda avatar Feb 26 '24 19:02 behda

Looks like the Docker build failed.

nibanks avatar Feb 28 '24 15:02 nibanks