msquic icon indicating copy to clipboard operation
msquic copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Only Pass ECN if Not non-ECT (Windows)

Open nibanks opened this issue 3 years ago • 2 comments

Description

Remove ECN ancillary data if not actually passing a non-ECT value.

Testing

Automated tests (mostly perf)

Documentation

N/A

nibanks avatar Oct 14 '22 12:10 nibanks

Do we wanna do this for other datapaths?

csujedihy avatar Oct 14 '22 17:10 csujedihy

Do we wanna do this for other datapaths?

I don't think it's super necessary. I just did it here because there is a known perf problem with hitting the slow path on Windows. That said, perf is actually slower with this change. Still investigating why, but it seems that by making the send faster, we make the RX slower.

nibanks avatar Oct 14 '22 19:10 nibanks