microsoft
Update run-perf_tests.py
This fixes nothing.
The sha1 hash is just used to create a hashtable (PerformanceResults in get_driver_id) and doesn't have to be cryptographically secure.
For tests the performance is more relevant.
@DanielRuf It's strange that this is a pull request since it is already committed to the dev branch here: https://github.com/microsoft/msphpsql/commit/30ed4b551d8144b2f43503048825f3ad421fb5e4
To me the last 48 commits to this repository (all made by the same individual) are troubling. They all have a commit message of the form "Update {filename}", without any details about what was changed or the reason for it. It looks like someone was just experimenting with incomplete changes which should have been on their own test branch rather than the default branch of the repository.
To me the last 48 commits to this repository (all made by the same individual) are troubling. They all have a commit message of the form "Update {filename}", without any details about what was changed or the reason for it. It looks like someone was just experimenting with incomplete changes which should have been on their own test branch rather than the default branch of the repository.
Probably not best practice, but I don't even see a CONTRIBUTING.md. Microsoft should enforce some proper rules.
Let's see how development will continue. So far it's not ideal, that'S for sure.