microsoft
[BUG] cmake_minimum_required should be set to a more reasonable value
Project MSIX SDK
Describe the bug
Commit d375318f01023aa2c2f8d685e804e6c979e10d89 changed cmake_minimum_required to 3.29.0, but I do not see any technical reason for this specific value to have been chosen and it breaks building on systems like Debian stable which is still at 3.25.1, for example.
I can manually change the cmake_minimum_required to 3.25 and build using makeLinux.sh and get working binaries without any issues. The cmake_minimum_required should be the actual minimum required version, not necessarily the version your CI pipeline happens to be using, at least if you intend for others to be able to clone the repo and build it on their systems too.
Yes, it's trivial to just change the value across all the CMakeLists.txt files myself and alternatively there actually is a CMake 3.29 package in Debian stable-backports if it ever really become necessary, but it seems strange to break people's builds that were previously working when it isn't actually necessary.
I concur with this one. I had to sed -i all the CMakeLists.txt files in order to be able to compile the project under debian 12 (bookworm) which was shipped with the cmake 3.25 stable branch. Ubuntu 24.04 is shipped with cmake 3.28. on Oracle Linux 9 and most RHEL 9 derivative (Alma, Rocky...), it's 3.26. On Fedora 41, it's 3.28.
Versions >= 3.29 are available on rolling release distributions and on "less stable" distribution (I mean, distributions that will be EOL'ed sooner than LTS distributions), but expecting that all linux developpers will have it is a bit dangerous (we also appreciate having a stable development environment :)).
For reference,
sed -i 's/cmake_minimum_required(VERSION 3.29.0/cmake_minimum_required(VERSION 3.25.0/' $(find -name CMakeLists.txt)
does the job.
