monaco-editor icon indicating copy to clipboard operation
monaco-editor copied to clipboard

When we are pressing the tab key, Keyboard focus moves to hidden control and gets lost completely on dismissing 'Find & Replace' popup:A11y_Monacoeditor_Focusorder.

Open AnKushSingh05 opened this issue 1 year ago • 1 comments

GitHubTags:

#A11yTCS;#Desktopweb;#Win11;#Visual Studio Code Client;#VisualStudioCode-Web-Apr2021;#a11y-monacoeditor;#Keyboard;#WCAG2.4.3;#A11yMAS;#A11ySev2;#SCIM:bug29252070;

Environment Details:

#URL: Monaco Editor (microsoft.github.io) Monaco Editor Chromium edge Version: 126.0.2592.68 (Official build) (64-bit).

Repro Steps:

  1. Hit the URL: https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0-dev.20230707#XQAAAAJzAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzfibW_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKimARHSWlrTPOQHROITHxmAetfeRrm3VHdSe7_Etv6WpgzlH4vE8EOD3EPhJDl6tDpOO8RxKZbUytKns3T0NFFloo9Q21KsEBT298I6cyZc5-Glup9UHU6QTpv2Hjab6pZzB3ZO2RH-WGhzXse2-hNlgz6zCgsG8AjiqGg0ZzWzND7z09NmCQOQd6pfkNvO2zmMzFvHpTY8RFEy1urlQcQMb1HHLEESBi8m3Rr3UzFlKzY51hfYcz__QCePc and press enter
  2. Tab till Monaco editor code.
  3. Press Ctrl+F to open the find and replace popup
  4. Verify whether When we are pressing the tab key, Keyboard focus moves to hidden control and gets lost completely on dismissing 'Find & Replace' popup

Actual Behavior

When we are pressing the tab key, Keyboard focus moves to hidden control and gets lost completely on dismissing 'Find & Replace' popup

Expected Behavior

Keyboard focus should be visible properly on dismissing 'Find & Replace' popup and navigating using the tab key.

User Impact:

Keyboard users will get confused where the keyboard focus is going if it is going to hidden control.

Attachment:

https://github.com/user-attachments/assets/a042e17b-e087-4f72-b432-b1585b7a18d5

AnKushSingh05 avatar Sep 06 '24 13:09 AnKushSingh05

SCIM:bug 29252070

AnKushSingh05 avatar Sep 13 '24 12:09 AnKushSingh05

This seems like an invalid issue. After you escape the find widget, focus moves to the editor. Then you press the tab key and it probably goes to the browser. Where are you expecting tab focus to move in this case?

I suggest closing this.

meganrogge avatar Oct 30 '24 19:10 meganrogge

I cannot reproduce this issue.

Can you reproduce this in VS Code? If so, pls create an issue for that. Otherwise, I suggest closing this.

meganrogge avatar Nov 13 '24 16:11 meganrogge

Verified the issue in below environment. https://microsoft.github.io/monaco-editor/playground.html?source=v0.40.0-dev.20230707#XQAAAAJ2AQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzgnYu_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKimARHSWlrTPOQHROITHxmAetfeRrm3VHdSe7_Etv6WpgzlH4o4auEDM7airf4dkfpT2Zvm8TjThwnHjr-wpcOd1wh2otkiOeFlbXVjecoLr1OVj_L0iJSnS-nwZz-T5hHECoHjGV0Buu_isN5TABNGo2g0P9ZDS-xHjfRHVmfQaywYwS7GlfzZzR78cZTB9DwiX0y-5gjZOUvyz1t0jMb2iOahwtVaTIOxyAgqH8ldoEsnFCB97Daz2bg_3mNQw Issue is fixed. Hence closing the bug https://github.com/user-attachments/assets/85815785-64c7-4ec5-9ea5-22f9575ef3fc

AnKushSingh05 avatar Dec 02 '24 05:12 AnKushSingh05

#closed #A11yFixed

meganrogge avatar Oct 11 '25 12:10 meganrogge