monaco-editor icon indicating copy to clipboard operation
monaco-editor copied to clipboard

Updated vscode-json-languageservice to 5.3.9

Open harrismirza opened this issue 1 year ago • 8 comments

Updated vscode-json-languageservice to the latest version, in order to fix the bug where validating JSON against the latest JSON Schema Drafts would not work correctly (https://github.com/microsoft/vscode-json-languageservice/issues/122)

harrismirza avatar Jan 21 '24 17:01 harrismirza

@microsoft-github-policy-service agree

harrismirza avatar Jan 21 '24 17:01 harrismirza

Just to add, this would also resolve issues #3625, #4114 and #3160

@hediet @aeschli Would you be able to review this?

harrismirza avatar Mar 11 '24 14:03 harrismirza

Wondering if this will be included in the March release, am heavily invested in seeing support for 2020-12 schema support. Am willing to help out in any way I can.

daviesgeek avatar Mar 22 '24 17:03 daviesgeek

@daviesgeek full 2020-12 schema support is still not implemented in vscode-json-languageservice. There's currently no resources to work on this on our side.

aeschli avatar Mar 28 '24 08:03 aeschli

Hey @aeschli, @deepak1556,

Is there a reason this wasn't included with the March release? I was looking forward to using this.

Even though this doesn't include full schema 2020-12 support, currently just having the schema property set to anything newer than draft-07 completely breaks validation.

harrismirza avatar Apr 02 '24 09:04 harrismirza

Hey, sorry to keep asking about this, but is there a particular reason this merge keeps being pushed?

harrismirza avatar Apr 30 '24 08:04 harrismirza

Same question. I've been telling customers that it is coming, first in March, then April, and now May.

jrsquared avatar Apr 30 '24 12:04 jrsquared

Same here

daviesgeek avatar Apr 30 '24 16:04 daviesgeek

Thanks for the PR and sorry for the delay! Just updated all of the langugae services.

hediet avatar May 03 '24 09:05 hediet

Thank you!

jrsquared avatar May 03 '24 12:05 jrsquared

Why didn't the update to languageservices make it in 0.49?

jrsquared avatar May 25 '24 23:05 jrsquared

Seems like publishing is not done by CI/CD, so maybe someone forgot to update node modules before publishing... 🙄

elisherer avatar May 26 '24 05:05 elisherer

@hediet Can we confirm that this will make it into the 0.50 release?

jrsquared avatar Jun 09 '24 00:06 jrsquared

Seems to be added to 0.50.0 (using 5.3.11)

But, I get the error

{
"$schema": "https://json-schema.org/draft/2019-09/schema",
// The schema uses meta-schema features ($recursiveRef) that are not yet supported by the validator
}

elisherer avatar Jun 25 '24 08:06 elisherer