monaco-editor
monaco-editor copied to clipboard
microsoft
Update TypeScript to TS 5.4.5 in all projects, vendored files
This commit updates the version of TypeScript vendored into the monaco-editor (via npm run import-typescript) to the latest version (5.3.3). It also aligns the explicit TypeScript dependencies throughout the repo for "typescript" to match.
This upgrade is essential to ensure monaco-editor can provide accurate diagnostics for JSX when using the latest React types (ex. via addExtraLib()), given the introduction of JSX.ElementType and associated changes to TypeScript support for JSX introduced in TypeScript 5.1.
cc: @jakebailey (as this follows your example from #3721)
VSCode already supported TypeScript 5.3 few months ago. Why this PR is hanging so long?
Updated to upgrade to TypeScript v5.4.2 now.
Recapping - the changes introduced by this PR were:
- bumping the version of TypeScript in all of the
package.jsonfiles (and tsdocs for the website to be compatible) - running
npm iandyarn install(for the website) for the affected packages - executing the pre-existing
import-typescriptscript from the root package.json to generate the vendored files
I completely understand if it is awkward to accept the PR given the large amount of generated / vendor code. Perhaps a maintainer could pull this PR locally and then re-run the import-typescript script to validate that the PR contains the unmodified outcome of the script your team created (i.e. no changes to commit).
@hediet Noticed your recent bumps to other dependencies. Can you help with this? (see also #4412)
FWIW you probably want to wait for 5.4.4, just because it has some critical bugfixes.
Is there any progress on this PR? Will we have access to the updated TS version at some point soon?
@hediet - apologies for the ping, but does this need approval from another maintainer?
It looks like CI is locked up on Community PR Approvals.
Delay was on me. I was reviewing and noticed an issue while doing so, and then I used this PR to investigate the issue I was seeing.
Delay was on me. I was reviewing and noticed an issue while doing so, and then I used this PR to investigate the issue I was seeing.
Thank you both so much for getting this PR over the finish line :)
We use this PR several months, glad to see it finally be merged, hope the new version will be released soon so we can switch back to the official release. Thank you!
