monaco-editor tune(monaco-editor-webpack-plugin): replace editor.main.js

tune(monaco-editor-webpack-plugin): replace editor.main.js

Open ValeraS opened this issue 3 years ago • 6 comments

Usually editor functionality used as:

import * as monaco from 'monaco-editor';

this resolves to ./esm/vs/editor/editor.main.js in package.json.

editor.main.js includes all feature and languages. Because of this, webpack-plugin does not work as expected.

This PR proposes replacing editor.main.js with editor.api.js and requested features and languages.

Closes #2874

Dec 30 '21 14:12 ValeraS

Thanks for your PR! Can you please open an issue to describe the problem that this PR fixes?

Jan 03 '22 08:01 hediet

Thanks for your PR! Can you please open an issue to describe the problem that this PR fixes?

Should I open an issue with text from the first comment or should I describe something more fully?

Jan 03 '22 14:01 ValeraS

Please also describe what you mean with "does not work as expected". Thank you!

Jan 03 '22 14:01 hediet

Maybe also need to change this line https://github.com/microsoft/monaco-editor/blob/a385674a34a33947483e0f7266b5a7dbcefe9b9d/webpack-plugin/src/index.ts#L315 to check only editor.main.js

Jan 03 '22 17:01 ValeraS

Great idea!

To test this change, we adopted the smoke-test to import monaco-editor (instead of ./esm/vs/editor/editor.api.js), but unfortunately this breaks CI now. Can you look into it?

Thank you!

Feb 03 '22 15:02 hediet

👍 👀