moaw icon indicating copy to clipboard operation
moaw copied to clipboard

[Issue] Some workshops cannot be found through search engine

Open lgmorand opened this issue 2 years ago • 5 comments

https://github.com/microsoft/moaw/blob/main/packages/database/external.yml#L121

How can it be not listed ? even without the search engine

lgmorand avatar Aug 25 '23 09:08 lgmorand

some other workshops are missing. something is wrong with building the DB

lgmorand avatar Aug 25 '23 09:08 lgmorand

it seems that it comes from the lang filter but I don't have UI to change it.

https://moaw.dev/catalog/?lang=fr

lgmorand avatar Aug 25 '23 10:08 lgmorand

Yes currently the language filter is implemented but the UI to switch languages and show the different available languages for a workshop is not built yet, that's something I need to work on. As a workaround, you can use this URL https://moaw.dev/catalog/?lang=all to display all workshops regardless of the language

sinedied avatar Aug 29 '23 07:08 sinedied

Should the UI should consider language = "all" is not parameter is set ?

lgmorand avatar Aug 29 '23 11:08 lgmorand

It's usually weird to see content listed which is not your primary languages (some workshop are in portuguese for example) and it would be a bit messy to have it as the default. The 'all' value was added more as a temporary workaround for not having a built-in language selector. Adding the language selector was next on my priority list, but unfortunately I have urgent requests on other projects that keeps adding, so I won't be able to work on that anytime soon

sinedied avatar Aug 29 '23 12:08 sinedied