microsoft-ui-xaml
microsoft-ui-xaml copied to clipboard
CueStyler: Fix outline rendering of TimedTextCue elements
trafficstars
The current method of simulating text outlines is wrong in the way how the visuals are offset in diagonal directions.
Also, the number of visuals for simulating the effect is insufficient for creating an acceptable appearance.
I will follow up with some comparisons.
Comparison 1: Large Outline Values
Current Implementation
This PR but with 8 Iterations
This PR but with 16 Iterations
This PR (using 32 Iterations)
Comparison 2: Smaller Outlines, Bold and Rounded Font
Current Implementation
This PR but with 8 Iterations
This PR but with 16 Iterations
This PR (using 32 Iterations)
Comparison 2b: Same as 2 but scaled to 200%
Current Implementation
This PR but with 8 Iterations
This PR but with 16 Iterations
This PR (using 32 Iterations)
Further improvement would be to:
- Remove the alpha component from the outline color before setting it on the elements
- Put all outline elements into a common container
- Set the alpha value of the outline color as opacity on that common container
- This will also allow to implement TimedTextStyle.OutlineRadius (which is currently ignored) by applying a blur effect to that common container
@bpulliam - What does the removal of the "needs-triage" label mean? What is the outcome of your triage?
@bpulliam Could this PR be reviewed please?