mcp
mcp copied to clipboard
Add Azure Managed Lustre Filesystem Import Job Create
What does this PR do?
Adds azmcp azuremanagedlustre filesystem import-job create and required testing and docs. [#318]
GitHub issue number?
Pre-merge Checklist
- [x] Required for All PRs
- [x] Read contribution guidelines
- [x] PR title clearly describes the change
- [x] Commit history is clean with descriptive messages (cleanup guide)
- [x] Added comprehensive tests for new/modified functionality
- [x] Updated
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)
- [x] For MCP tool changes:
- [x] One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
- [x] Updated
README.mddocumentation - [x] Updated command list in
/docs/azmcp-commands.md - [x] Updated test prompts in
/docs/e2eTestPrompts.md - [x] For new or modified tool descriptions, ran
ToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test prompts
- [ ] 👉 For Community (non-Azure team member) PRs:
- [ ] Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (
crypto mining, spam, data exfiltration, etc.) - [ ] Manual tests run: added comment
/azp run mcp - pullrequest - liveto run Live Test Pipeline
- [ ] Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (
Some questions:
- I had to tweak/fix some other files such as the test resources deployment script. That is not in the scope for this additional command. For the future, should fixes like that be in a separate PR or part of a PR like this?
- After running the tool description script, there were some changes made to other files like the eng\tools\ToolDescriptionEvaluator\prompts.json and eng\tools\ToolDescriptionEvaluator\results.txt. Should those changes be included? Many of the changes were in sections that are not Azure Managed Lustre related. Should I only include changes that are Azure Managed Lustre related?
Failed live tests are related to the test resources bicep file not creating HSM enabled AMLFS quite yet. This PR for AMLFS create should solve this issue.
@wolfgang-desalvador
Make sure to update consolidated-tools.json](https://github.com/microsoft/mcp/blob/main/core/Azure.Mcp.Core/src/Areas/Server/Resources/consolidated-tools.json). You can find instructions in https://github.com/microsoft/mcp/blob/main/CONTRIBUTING.md