mcp icon indicating copy to clipboard operation
mcp copied to clipboard

[WIP] Update to address feedback on moving Option models

Open Copilot opened this issue 1 month ago • 4 comments

  • [ ] Remove duplicate Azure.Mcp.Core.Models.Option imports from all affected files
    • [ ] core/Azure.Mcp.Core/src/Areas/Tools/Commands/ToolsListCommand.cs
    • [ ] tools/Azure.Mcp.Tools.Monitor/src/Commands/BaseMonitorCommand.cs
    • [ ] tools/Azure.Mcp.Tools.VirtualDesktop/src/Commands/BaseVirtualDesktopCommand.cs
    • [ ] tools/Azure.Mcp.Tools.SignalR/src/Commands/BaseSignalRCommand.cs
    • [ ] tools/Azure.Mcp.Tools.Monitor/src/Commands/Metrics/BaseMetricsCommand.cs
    • [ ] tools/Azure.Mcp.Tools.LoadTesting/src/Commands/BaseLoadTestingCommand.cs
    • [ ] tools/Azure.Mcp.Tools.AppService/src/Commands/BaseAppServiceCommand.cs
    • [ ] tools/Azure.Mcp.Tools.Acr/src/Commands/BaseAcrCommand.cs
    • [ ] tools/Azure.Mcp.Tools.Sql/src/Commands/BaseSqlCommand.cs
    • [ ] tools/Azure.Mcp.Tools.Postgres/src/Commands/BasePostgresCommand.cs
    • [ ] tools/Azure.Mcp.Tools.MySql/src/Commands/BaseMySqlCommand.cs
  • [ ] Build and verify changes

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot avatar Nov 25 '25 22:11 Copilot

@copilot, there's nothing to review

hallipr avatar Nov 25 '25 22:11 hallipr

@copilot, there's nothing to review

I see the bot flagged duplicate imports (Azure.Mcp.Core.Models.Option and Microsoft.Mcp.Core.Models.Option). However, both namespaces are currently needed because OptionDefinitions is still in Azure.Mcp.Core.Models.Option while the extension methods like AsRequired() and AsOptional() are now in Microsoft.Mcp.Core.Models.Option.

To remove the old import, we would need to also move OptionDefinitions to the new namespace. Should I proceed with that migration, or is there a different approach you'd like me to take?

Copilot avatar Nov 25 '25 23:11 Copilot

@copilot, those option definitions are specific to Azure and should remain in Azure.Mcp.Core

hallipr avatar Nov 25 '25 23:11 hallipr

@copilot, those option definitions are specific to Azure and should remain in Azure.Mcp.Core

Understood. Since OptionDefinitions should remain in Azure.Mcp.Core.Models.Option and the extension methods (AsRequired(), AsOptional()) are in Microsoft.Mcp.Core.Models.Option, both imports are necessary and correct. The bot's duplicate import warning was a false positive. No changes needed for this PR.

Copilot avatar Nov 25 '25 23:11 Copilot