magentic-ui icon indicating copy to clipboard operation
magentic-ui copied to clipboard

[Frontend] Linting

Open stefanoamorelli opened this issue 6 months ago • 4 comments

I've noticed that with a simple eslint configuration, frontend/ returns ✖ 248 problems (70 errors, 178 warnings). Especially as the codebase grows, I would suggest to tackle this issue sooner rather than later and:

  • implement a common eslint.config.js for consistency across different contributors;
  • enforce a lint check via a GitHub workflow;
  • solve the existing linting issues.

I would be happy to help with the three!

On backend we already have ruff but frontend/ is lacking linting checks.

stefanoamorelli avatar May 28 '25 21:05 stefanoamorelli

Hi @stefanoamorelli thank you for bringing that up! It would be great if you could help with the three.

matheusmaldaner avatar May 29 '25 21:05 matheusmaldaner

@matheusmaldaner, sure, happy to help, I'm on it!

stefanoamorelli avatar May 29 '25 21:05 stefanoamorelli

Hi @stefanoamorelli let me know if you ever got around to this or if you would like me to cover it!

matheusmaldaner avatar Jun 11 '25 22:06 matheusmaldaner

@matheusmaldaner almost done expect it ready to review by tomorrow EOD 🙌

stefanoamorelli avatar Jun 12 '25 16:06 stefanoamorelli