gVNIC 1.0.0 does not support checksum offloads(?), does it need to be fatal ?

Open HaseebLUMS opened this issue 11 months ago • 2 comments

I am running into the following fatal error while starting machnet.

=> Hardware does not support checksum offloads.

Driver information: driver: gve version: 1.0.0

capabilities (via ethtool -k)

tx-checksum-ipv4: off [fixed]

Jan 23 '25 01:01 HaseebLUMS

In the source code, here is the issue

// Making this fatal; not sure what NIC does not support checksum offloads.
LOG(FATAL) << "Hardware does not support checksum offloads.";

Jan 23 '25 01:01 HaseebLUMS

Hi @HaseebLUMS

Would ya have a look at this commit https://github.com/microsoft/machnet/commit/93f14721ba9609c00639cc40e1af062ddc4c9154

Mainly, this particular file src/core/drivers/dpdk/pmd.cc

You are right and it does not have to be FATAL. Feel free to change it to WARNING and see if it solves your problem.

Also, feel free to create PR, and clean up GCP support. Happy to review and help out.

Thanks, Alireza

Jan 23 '25 10:01 sarsanaee