live-share icon indicating copy to clipboard operation
live-share copied to clipboard

Jupyter Notebook Integration

Open GeorgeLertzmanLepofsky opened this issue 2 years ago • 9 comments

Hello,

Thank you for your work on Live Share and the existing integration of Jupyter notebooks. However, the existing implementation of Notebooks is effectively non-functional for anything beyond simply looking at the file, as changes do not update live/users cannot see cursors/follow does not work. The linked wiki doc is from a year ago and discusses these issues, so I am wondering if any progress has been made. Is it still recommended to use the Insiders build?

Thank you


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

GeorgeLertzmanLepofsky avatar Oct 11 '22 21:10 GeorgeLertzmanLepofsky

Hi, thank you for letting us know. If you have any Live Share logs that would be super helpful . Please attach them to this thread. Yes please keep using the insiders build.

setaskin avatar Oct 11 '22 23:10 setaskin

Of course. Where might I find them?

GeorgeLertzmanLepofsky avatar Oct 14 '22 21:10 GeorgeLertzmanLepofsky

You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue.

setaskin avatar Oct 19 '22 00:10 setaskin

@setaskin Are there any updates? I'm having the same issue. Steps to reproduce: (steps starting with '>' are command pallet commands)

  1. Open VSCode in a folder with a notebook. (We'll call this window - A)
  2. A: Open notebook file (test.ipynb)
  3. A: > Clear Cell Outputs
  4. A: >start collaboration session (share)
  5. A: File > New window (We'll call this new window - B)
  6. B: >join collaboration session
  7. B: Paste the link and press enter
  8. B: Get the warning Co-editing is not supported for notebooks opened with non-shared views.
  9. B: Open test.ipynb
  10. B: Try to execute a cell with a print statement (this might bring up the allow executing request, I think I have clicked always allow)
  11. B: Try to run cell 1 and 2
  12. See the HTML output appear on window A but not B.
  13. Export logs from A and B.

The ogs: B.zip A.zip

Jupyter notebok content:

# %%
from matplotlib import pyplot as plt
from bokeh.models import HoverTool
from hvplot import pandas
from dateutil import parser
import panel as pn
import pandas as pd
import numpy as np
import holoviews as hv
from typing import List
from os import path
import scipy
import scipy.optimize
import scipy.special
import scipy.signal
from functools import reduce
import operator
import glob
import datetime
from IPython.core.interactiveshell import InteractiveShell
from tqdm.notebook import trange, tqdm
from copy import deepcopy
import json
import operator

# %%
df = pd.DataFrame(data={'x':[1,2], 'y':[1,2]})
df.hvplot(x='x', y='y')

# %%
print('hi')

image

TwoUnderscorez avatar Nov 11 '22 11:11 TwoUnderscorez

@GeorgeLertzmanLepofsky we are working on a bunch of fixes in this area to improve the regressed Notebook experience. CC: @setaskin @nandiniYeltiwar for updates.

fubaduba avatar Dec 01 '22 19:12 fubaduba

Updates on notebook bugs:

  1. Follow or cursor highlight/selection - fixed in latest release
  2. Co-editing broken with error message: Co-editing is not supported for notebooks opened with non-shared views. - investigating
  3. Cell execution does not show up on guest - investigating

nandiniYeltiwar avatar Dec 02 '22 19:12 nandiniYeltiwar

@TwoUnderscorez , Hi , we are looking into this issue but meanwhile there is a workaround you can use. In your scenario if guest (Window B) selects a notebook controller, It will fix the issue. Pease refer the below screen shot. Check out the top right button and select the controller from the opened list. controller

setaskin avatar Dec 07 '22 22:12 setaskin

Issue is filed on VS Code side: https://github.com/microsoft/vscode/issues/167887

setaskin avatar Dec 15 '22 23:12 setaskin