live-share icon indicating copy to clipboard operation
live-share copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Images dragged into Live Share Session by guests are corrupted

Open jorenbroekema opened this issue 3 years ago • 4 comments

Describe what happened:

Images dragged into Live Share Session by guests are corrupted.

image

I saw this was fixed here https://github.com/MicrosoftDocs/live-share/issues/1895 and I got the latest release of live share, but it's still not working apparently, at least for .jpg files dragged and dropped by participants.

What was your system configuration? Product and Version [VS/VSCode]: 1.64.2 OS Version[macOS/Windows]: Windows 10 Home Live Share Extension Version: v1.0.5330 Target Platform or Language [e.g. Node.js]: Node v14.16.0

Steps to Reproduce / Scenario:

  1. Start a live share session
  2. Invite a guest
  3. Guest drags and drops a .jpg from windows file explorer into VS code
  4. Try opening it in VS Code, it's corrupted

jorenbroekema avatar Feb 11 '22 09:02 jorenbroekema

@setaskin

daytonellwanger avatar Feb 15 '22 18:02 daytonellwanger

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically in 2 days.

github-actions[bot] avatar Aug 15 '22 10:08 github-actions[bot]

Still an issue last time I checked (month ago or so?) and haven't had an update here suggesting it's fixed, so, making it unstale :)

jorenbroekema avatar Aug 15 '22 10:08 jorenbroekema

Thanks for pinging on this @jorenbroekema. We will add it to our bugs to fix.

fubaduba avatar Dec 01 '22 19:12 fubaduba

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. We understand this may be disappointing; we've all been there, whether in this project or others we've contributed to. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it’s for you.

derekbekoe avatar Mar 21 '24 17:03 derekbekoe

I think this issue definitely deserves to stay open.

Adding binary files to a live share session may not be common for some, but when you're working in a frontend context, it is fairly common to add binary assets such as images, icons, favicons, etc.

Not being able to do so, without any error or warning, makes this really confusing for users.

It's really quite painful to have to restart live share sessions every time anyone in the session wants to add such an asset, especially when prototyping websites collaboratively this is quite a blocker.

Would you consider reopening?

jorenbroekema avatar Mar 22 '24 16:03 jorenbroekema

this has been an issue for years. insane how its not gonna get fixed

not-nullptr avatar May 23 '24 19:05 not-nullptr