live-share icon indicating copy to clipboard operation
live-share copied to clipboard

Can't open a vscode.dev link in Visual Studio Code Live Share (on desktop)

Open jamgregory opened this issue 4 years ago • 8 comments

Describe what happened: I sometimes collaborate with colleagues via Google Meet, which I run on a separate machine to my development desktop.

If I click a Live Share link they have sent me (e.g. one starting https://prod.liveshare.vengsaas.visualstudio.com/join?...), then it automatically opens in vscode.dev on my Google Meet machine. This is fine, except I'd like to open the link in Visual Studio Code on my development desktop.

However, it's not possible to get the original link bank - and the Live Share extension returns an InvalidHostname error when trying to join the session.

What was your system configuration? Product and Version [VS/VSCode]: VSCode 1.62.2 OS Version[macOS/Windows]: Linux (Ubuntu 20.04) Live Share Extension Version: 1.0.5090 Target Platform or Language [e.g. Node.js]: Ruby on Rails

Steps to Reproduce / Scenario:

  1. Copy a valid vscode.dev URL (e.g. one beginning https://vscode.dev/liveshare/...)
  2. Open Visual Studio Code
  3. Select the Live Share extension and click Join
  4. Enter the vscode.dev URL
  5. The error InvalidHostname is displayed

Please attach logs to this issue: vscode-liveshare-logs.zip

jamgregory avatar Nov 17 '21 11:11 jamgregory

Hey @jamgregory , I'm not able to reproduce this. Could you ensure you're on the latest version of Live Share and that you've correctly copied the vscode.dev link and try again?

daytonellwanger avatar Nov 18 '21 17:11 daytonellwanger

Hey @daytonellwanger :wave:

I seem to be on the latest release of Live Share (1.0.5090) and same for VSCode (1.62.2-1636665017). I've just tried it again using a vscode.dev link and it's still showing InvalidHostname after I enter the URL into the Join box.

jamgregory avatar Nov 18 '21 17:11 jamgregory

I've done a quick bit of digging, and in extension-prod.js on line 197993, it's checking if linkHostname and workspaceHostname are the same - in my case, linkHostname is vscode.dev and workspaceHostname is prod.liveshare.vengsaas.visualstudio.com, which is why it's failing.

jamgregory avatar Nov 18 '21 17:11 jamgregory

Hmmm I'm really not sure what could possibly be different between our setups. Could I bother you to make a recording of

  • Sharing the session
  • Opening in the browser
  • Copying the vscode.dev link
  • Opening in the desktop (and receiving this error)

Thanks! I'm just not sure how to proceed since it seems to be working on my end.

daytonellwanger avatar Nov 18 '21 17:11 daytonellwanger

Thanks for that pointer! Let me see if I can find anything based on that..

daytonellwanger avatar Nov 18 '21 17:11 daytonellwanger

Hey @daytonellwanger :wave:

Not sure if you've had chance to investigate this further. I've just done a further test locally, and the same thing happens if I start using https://vscode.dev, start a new Live Share session then try to join it from my VS Code app on my laptop. However, vscode.dev accepts Live Share links from my local machine and will join them as expected.

If it helps, the Live Share feature set on my local machine is using stable - not sure if support for vscode.dev is perhaps in the insiders build?

jamgregory avatar Nov 25 '21 15:11 jamgregory

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically in 2 days.

github-actions[bot] avatar Aug 15 '22 10:08 github-actions[bot]

I don't know if this is still an issue unfortunately - I've not had any further updates from @daytonellwanger or the VS Code team.

jamgregory avatar Aug 16 '22 09:08 jamgregory

Apologies for the delay here. As is, this issue doesn’t have enough information to be reproduced. Please reopen if the issue persists with any additional details. Thank you.

derekbekoe avatar Nov 12 '22 05:11 derekbekoe