live-share icon indicating copy to clipboard operation
live-share copied to clipboard

Liveshare slow down the whole PC by saturating SSD query queue.

Open Kuinox opened this issue 4 years ago • 7 comments

Describe what happened:

What was your system configuration? Product and Version [VS/VSCode]: VS 16.9.5 OS Version[macOS/Windows]: Live Share Extension Version: 1.0.3587.1 Target Platform or Language [e.g. Node.js]: C# Steps to Reproduce / Scenario:

  1. Run LiveShare
  2. Someone join the session.

Now you can witness SSD high usage (but the bandwidth usage is really low, below 1Mo/s) image Now procmon show that something is happening: image Liveshare logs to a file, and almost flush for every log line (1.3 log per flush~). image

The logfile being written: 20210515_145034_Agent.log

Kuinox avatar May 15 '21 16:05 Kuinox

It looks like liveshare logs a lot, and because Trace.AutoFlush is set to true, each logged line causes a flush to the logfile.

Kuinox avatar May 15 '21 19:05 Kuinox

Thanks for the report @Kuinox . I think you're right that our logs are too verbose and we may flush too often. Let me look into making the default log level less verbose and reducing how often we flush.

daytonellwanger avatar May 29 '21 00:05 daytonellwanger

Hello ! Is this issue still considered ? Is there any way we can help on this issue ? My team is using Liveshare on a daily basis to do mob programming with 4 developers connected. VS Code becomes really unresponsive since a few month ago during our coding sessions 😟

abalhier avatar Jul 30 '21 15:07 abalhier

Hey @abalhier, we're currently working on it and should have something that'll help in the next release or so.

daytonellwanger avatar Aug 04 '21 17:08 daytonellwanger

Hey @abalhier, we're currently working on it and should have something that'll help in the next release or so.

Still working on it?

patrickklaeren avatar Mar 30 '22 22:03 patrickklaeren

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically in 2 days.

github-actions[bot] avatar Aug 15 '22 10:08 github-actions[bot]

Bumpity bump bump @daytonellwanger

patrickklaeren avatar Aug 15 '22 11:08 patrickklaeren

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. We understand this may be disappointing; we've all been there, whether in this project or others we've contributed to. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it’s for you.

derekbekoe avatar Mar 21 '24 17:03 derekbekoe