live-share icon indicating copy to clipboard operation
live-share copied to clipboard

Sign in using GitHub Enterprise or ADFS Account

Open MichaelAndCara opened this issue 7 years ago • 52 comments

Request

Not sure if it's already in the works, but will it be possible to sign in using a GitHub enterprise account, which is wired to our AD credentials?

Product and Version [VS/VSCode]: VSCode 1.22.2 OS Version [macOS/Windows]: Windows 10 Live Share Extension Version: 0.3.93 Target Platform or Language [e.g. Node.js]: any

Steps to Reproduce / Scenario:

  1. Sign In
  2. Choose github

MichaelAndCara avatar May 09 '18 17:05 MichaelAndCara

@MichaelAndCara Thanks for asking. If your organization uses Azure AD, you can sign into that account using the "Microsoft" path. We support AAD and personal Microsoft accounts. However, we do not support on-prem ADFS or on-prem GitHub. Does that meet your need?

Chuxel avatar May 10 '18 15:05 Chuxel

Our organization does not use AADs, but Devs do have Microsoft accounts, which we can use.

However, our employees in our IT department are guaranteed to have a "normal" AD account. I figured if we were mentoring anyone (employees interested in becoming developers, interns, etc), it would be convenient to use our GitHub enterprise account that is tied to our "normal" AD accounts.

Thanks @Chuxel

MichaelAndCara avatar May 11 '18 03:05 MichaelAndCara

@MichaelAndCara Got it. I'll flip this to a feature request given it sounds like in an ideal world you'd be able to use on-prem AD.

Chuxel avatar May 11 '18 21:05 Chuxel

Really need the on-prem AD feature. Most of the environments I work in don't allow any Azure access. All Azure access is done on a separate network.

HenryHW avatar Jan 29 '19 22:01 HenryHW

Github Enterprise support would be great.

spkane avatar Feb 27 '19 19:02 spkane

We would love to use this in our organization but require github enterprise support.

peteashworth avatar Mar 06 '19 14:03 peteashworth

@spkane @AshworthHub Out of curiosity: would on-prem AD support address your needs? Or would you specifically need GitHub Enterprise authentication?

lostintangent avatar Mar 06 '19 15:03 lostintangent

@lostintangent we would need github enterprise.

peteashworth avatar Mar 06 '19 15:03 peteashworth

@lostintangent Github Enterprise support. We are not a Windows shop, so AD support would not help us, but we do use GHE internally.

I would not expect this to be difficult, since as far as I know, it has all the same APIs. They usually just have a different base URL.

spkane avatar Mar 10 '19 21:03 spkane

This would be nice to have as an on prem solution, perhaps TFS integration?

mezafits avatar Mar 12 '19 12:03 mezafits

cc @avanderhoorn

legomushroom avatar Mar 12 '19 14:03 legomushroom

Suggest splitting this into two issues - I'm only interested in local AD support. (Some Github Enterprise users use it with AD, others don't).

Garen avatar Apr 02 '19 17:04 Garen

Agree simple ad/ldap is all we need too. We'll never do github enterprise since we have on prem Atlassian stack.

CalPolyRock avatar Apr 03 '19 00:04 CalPolyRock

Also need this.

Arshia001 avatar Apr 07 '19 12:04 Arshia001

Need this also

louisfischer avatar Apr 08 '19 22:04 louisfischer

In our company, we're developing in an completely disconnected environment with On Premise TFS and On Premise AD. So, on-prem ADFS is a must.

MichaelSteinecke avatar Apr 10 '19 12:04 MichaelSteinecke

We are also developing in a completely disconnected environment and on-prem ADFS is also a must for us.

RobFur avatar Apr 23 '19 07:04 RobFur

would be interested in an on premise solution for organizations with restricted external network access.

zhaoshouren avatar May 09 '19 12:05 zhaoshouren

One more for "totally disconnected environment" - LiveShare would be huge for us but t's currently DOA

allendcr avatar Jul 09 '19 12:07 allendcr

This feature for Live Share will be used by a lot of DoD contractors and government. Many times we are on offline networks for security reasons. The market for On-Premise is very large with governments.

BenBurge avatar Nov 01 '19 19:11 BenBurge

Hi, Does anyone have an update on this issue ? With the covid-19 out there, it would be very interesting for us to collaborate with this tool ! Thanks !

maximedasilva avatar Mar 23 '20 20:03 maximedasilva

Sure ! I'm working in a company relied to the french ministry of labour and, of course, we rely on ADFS Accounts. Live Share would be a really nice tool to use ! Thanks

NicolasVargas avatar Mar 24 '20 11:03 NicolasVargas

Same here, due to privacy and security reasons we can't use GHE, regular Github os Azure AD.

viralatron avatar Mar 25 '20 17:03 viralatron

Also could really use this due to CoVID-19. Can't use without either Github Enterprise or on-premise AD.

JamesCatt avatar Mar 25 '20 17:03 JamesCatt

this would be great indeed, even if it means "only direct mode"

tebeco avatar Mar 31 '20 16:03 tebeco

Support, an on premise solution with AD would greatly be appreciated.

malghabr avatar Apr 14 '20 17:04 malghabr

+1 for an on-prem solution. Our windows based Dev team would love to use this but cannot have offsite authentication.

dankelley2 avatar Apr 22 '20 16:04 dankelley2

If we could restrict live-share to our O365 tenant or our github enterprise oauth it would be a huge win for our developers working from home. With COVID-19 and our working from home situation this enhancement cannot come fast enough!

rpetersen3 avatar May 18 '20 12:05 rpetersen3

@rpetersen3 If you were able to use the existing Azure Active Directory-based auth, and just needed a way to restrict collaboration to members of your tenant, you could take a look at using this extension and see if it meets your needs in the near-term? That handles automatically blocking guests that are external to the host’s domain.

lostintangent avatar May 18 '20 14:05 lostintangent

Thanks, we will give it a try!

On Mon, May 18, 2020 at 10:09 AM Jonathan Carter [email protected] wrote:

@rpetersen3 https://github.com/rpetersen3 If you were able to use the existing Azure Active Directory-based auth, and just needed a way to restrict collaboration to members of your tenant, you could take a look at using this extension https://marketplace.visualstudio.com/items?itemName=vsls-contrib.gatekeeper and see if meets your needs in the near-term? That handles automatically blocking guests that are external to the host’s domain.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/live-share/issues/341#issuecomment-630207234, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHG63PKAF3AHO743KXZMMVLRSE6RRANCNFSM4E7C7JZQ .

rpetersen3 avatar May 19 '20 16:05 rpetersen3