live-share icon indicating copy to clipboard operation
live-share copied to clipboard

Allow Guest Command Control link doesn't show any help

Open rchiodo opened this issue 5 years ago • 8 comments

I enabled a code lens command in my extension and I'm trying to execute it in a live share session.

I get this error: image

The link for more info goes here: extensionUtil_1.ExtensionUtil.openBrowser('https://aka.ms/vsls-security#code-commands');

That anchor doesn't mention the setting to change.

rchiodo avatar Jan 22 '19 18:01 rchiodo

@lostintangent looks like we should publish a new section on the security page.

daytonellwanger avatar Jan 22 '19 18:01 daytonellwanger

Is there a fix for this?

NatoBoram avatar Jun 29 '20 13:06 NatoBoram

@NatoBoram , what's the issue you're running into? Missing documentation?

daytonellwanger avatar Jun 30 '20 01:06 daytonellwanger

When I click on "Add all missing imports", there's this message :

Code_-_Insiders_VCma5OifuE

This is despite the host explicitly allowing everything.

{
  "liveshare.allowGuestDebugControl": true,
  "liveshare.allowGuestTaskControl": true,
  "liveshare.languages.allowGuestCommandControl": true,
  "liveshare.openSharedServers": false,
  "liveshare.publishWorkspaceInfo": true,
}

When I click on "More info", I am redirected to this url : https://aka.ms/vsls-security#code-commands

But there's no #code-commands in the page.

NatoBoram avatar Jun 30 '20 15:06 NatoBoram

Thanks for the info! Let me see if we can repro. @aletsdelarosa , could you see if you're able to?

daytonellwanger avatar Jun 30 '20 20:06 daytonellwanger

Any news? #hope

jawn avatar Aug 11 '20 08:08 jawn

?

erlangparasu avatar Jun 08 '22 09:06 erlangparasu

Any progress with this issue?

vhsw avatar Sep 06 '22 17:09 vhsw

We’re not able to prioritize this issue over the other higher-impact issues we receive every week, based on the votes and comments from others in the community and our understanding of the issue. However, rest assured that we love your input. If you feel it deserves to stay open, then clarify your use case and contact us to let us know how severe it is for you.

derekbekoe avatar Mar 28 '23 20:03 derekbekoe