live-share-sdk icon indicating copy to clipboard operation
live-share-sdk copied to clipboard

[Feature Request]: Public Teams RoleVerifier and SharedClock setup

Open ryanbliss opened this issue 2 years ago • 3 comments

Describe your user scenario

If a developer wants to use our RoleVerifier or SharedClock, they must first use joinContainer. If a developer wants to use Live Share DDS for a custom container that doesn't use our mapping service, we currently force them to implement their own shared clock and role verifier, even if they want to use the Teams APIs.

Describe the solution you'd like

Either public exports for role verifier and shared clock or public API for initializing/starting those two services.

ryanbliss avatar Oct 07 '22 20:10 ryanbliss

does #61 solve this? To use a custom container, you end up implementing your own ILiveShareHost anyway

huntj88 avatar Oct 18 '22 21:10 huntj88

@ryanbliss and I were talking about adding a LiveShareClient.initialize() method that would initialize the Timestamp Provider and Role Verifier without the need to call joinContainer(). Should be an easy add.. @huntj88

Stevenic avatar Oct 18 '22 21:10 Stevenic

@Stevenic Would that be something that should maybe be a static function for those that don't want an instance of LiveShareClient if they plan to use AzureClient only?

(new LiveShareClient(altHost)).initialize() vs LiveShareClient.initialize(altHost)

image

huntj88 avatar Oct 18 '22 22:10 huntj88

Should be fixed with #562...at least mostly. Might still be improvements we can make long term, but I think the new AzureLiveShareHost and LiveShareRuntime implementations together make this easier.

ryanbliss avatar May 07 '23 22:05 ryanbliss