lisa icon indicating copy to clipboard operation
lisa copied to clipboard

Add Image Feature Requirements

Open kamalca opened this issue 10 months ago • 7 comments

Each feature can now implement a function create_image_requirement to determine a requirement based on the raw_capabilities of the image. The requirement is then merged with the platform requirement.

kamalca avatar Apr 08 '24 19:04 kamalca

@LiliDeng Do you have a Community Gallery Image I can test my changes on?

kamalca avatar Apr 23 '24 21:04 kamalca

@LiliDeng Do you have a Community Gallery Image I can test my changes on?

community_gallery_image: "southcentralus/FreeBSDCGTest-d8a43fa5-745a-4910-9f71-0c9da2ac22bf/FreeBSD-14.0-RC3-amd64-ufs-gen1-testing/latest"

please specify the location southcentralus

LiliDeng avatar Apr 24 '24 00:04 LiliDeng

@LiliDeng LGTM

squirrelsc avatar Apr 30 '24 04:04 squirrelsc

@kamalca could you please run a test with gallery arm64 image?

LiliDeng avatar May 06 '24 14:05 LiliDeng

@kamalca could you please run a test with gallery arm64 image?

Shared Image Gallery or Community Gallery Image?

kamalca avatar May 06 '24 23:05 kamalca

@kamalca could you please run a test with gallery arm64 image?

Shared Image Gallery or Community Gallery Image?

You need cover all scenarios, I hit one issue when run a test with Shared Image Gallery.

LiliDeng avatar May 06 '24 23:05 LiliDeng

@kamalca could you please run a test with gallery arm64 image?

Shared Image Gallery or Community Gallery Image?

You need cover all scenarios, I hit one issue when run a test with Shared Image Gallery.

I fixed a typo. Thank you for helping test the changes.

kamalca avatar May 07 '24 16:05 kamalca

@LiliDeng Any updates on this getting merged? I have to do more work to continually rebase, merge conflicts, and retest changes the longer this goes unmerged.

kamalca avatar May 16 '24 21:05 kamalca