lisa icon indicating copy to clipboard operation
lisa copied to clipboard

Enable Deployment of CVM

Open kamalca opened this issue 2 years ago • 4 comments

security_type can be TrustedLaunch or ConfidentialVm. secure_boot_enabled and v_tpm_enabled can both be True or False. These values can all be set through the runbook.

kamalca avatar Aug 01 '22 15:08 kamalca

Hello @squirrelsc, I have gotten CVM deployment to work. I wanted to sync with you again about design choices. This enables all three CVM related settings to be set through the runbook. I tried to leave the functionality of the existing security_profile feature intact. I was not sure how to best handle when runbook settings and testcase settings conflict. As written, the runbook settings will overwrite any testcase settings for security_profile.

kamalca avatar Aug 01 '22 15:08 kamalca

Hello @squirrelsc, I have gotten CVM deployment to work. I wanted to sync with you again about design choices. This enables all three CVM related settings to be set through the runbook. I tried to leave the functionality of the existing security_profile feature intact. I was not sure how to best handle when runbook settings and testcase settings conflict. As written, the runbook settings will overwrite any testcase settings for security_profile.

Overall, it's ok to me, except use less parameters. I think there is no test case conflict, because the secure_boot should be included in CVM. The parameter can be a NodeSpace, so the test case level can set it to secure boot or CVM. So the test case can be run on both settings.

squirrelsc avatar Aug 01 '22 16:08 squirrelsc

@kamalca is any restriction for the VM sizes which support TVM? currently, if the size supports v2, then the SecurityProfile feature will be added. if there is the restriction, we need add similar code like below in platform.py.

            elif name == "HyperVGenerations":
                if "V2" in str(sku_capability.value):
                    node_space.features.add(
                        schema.FeatureSettings.create(features.SecurityProfile.name())
                    )

LiliDeng avatar Aug 03 '22 12:08 LiliDeng

@squirrelsc I don't think this is quite right yet. I'd like your input on what I have so far. Thank you :)

kamalca avatar Aug 12 '22 22:08 kamalca