microsoft
Run CI for Java 8
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@baywet The SonarQube plugin for Gradle requires Java 17 to run causing compilation to fail with Java 8.
Should we consider switching to the GitHub action or find a way to tweak the build to not execute sonar tasks then run a separate ./gradlew sonarqube ... command in the workflows?
@Ndiritu that's an avenue we can explore. Another one would be to conditionally include the plugin based on the java version. Also the android api level is failing for the same reason. Since there's already a plugin in there to validate which APIs we're using, and since we're setting up CI to make sure the other scenarios not being validated by the linter are also being validated, I'm suggesting we revert the changes in that workflow. Thoughts?
@Ndiritu that's an avenue we can explore. Another one would be to conditionally include the plugin based on the java version. Also the android api level is failing for the same reason. Since there's already a plugin in there to validate which APIs we're using, and since we're setting up CI to make sure the other scenarios not being validated by the linter are also being validated, I'm suggesting we revert the changes in that workflow. Thoughts?
@baywet I opted to conditionally include the plugin based on the JVM version since the spotless plugin also has a min. requirement of Java 11 to execute.
If I understand correctly, you're suggesting that we add Java 8 CI checks to the linting workflow so that we cover both Android & Java 8 checks there?
Also, Java 8 build checks now fail at the tests. Should we downgrade the junit mockito libs & use Java-8 friendly syntax for tests as well? ie.. failures bc of using var keyword
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will take a look shortly.
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.
Conflicts have been resolved. A maintainer will take a look shortly.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud