kiota-http-dotnet icon indicating copy to clipboard operation
kiota-http-dotnet copied to clipboard
verified publisher icon microsoft

Add parameter to factory method for setting handler options

Open pschaeflein opened this issue 1 year ago • 5 comments

closes https://github.com/microsoft/kiota-http-dotnet/issues/233

pschaeflein avatar Apr 23 '24 17:04 pschaeflein

Also, did you start working on unit tests for that? Did you run into any issues with those?

Added tests to the PR. As mentioned in #233 , I cannot run the tests locally unless I remove the analyzer reference from the .csproj file.

pschaeflein avatar Apr 23 '24 22:04 pschaeflein

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

github-actions[bot] avatar Apr 24 '24 06:04 github-actions[bot]

No need to expedite. Thanks tho.

pschaeflein avatar Apr 24 '24 13:04 pschaeflein

@pschaeflein by expedite I meant "we don't want to have to open another PR just for the version bump because we're lazy" 🤣

baywet avatar Apr 24 '24 13:04 baywet

Conflicts have been resolved. A maintainer will take a look shortly.

github-actions[bot] avatar Apr 30 '24 06:04 github-actions[bot]

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

github-actions[bot] avatar May 21 '24 19:05 github-actions[bot]