kernel-memory icon indicating copy to clipboard operation
kernel-memory copied to clipboard

fix issue with elasticsearch extension to respect limit and minReleva…

Open basyonic opened this issue 1 year ago • 2 comments

…nce parameters when calling GetSimilarListAsync API

Motivation and Context (Why the change? What's the scenario?)

Fixing issue https://github.com/microsoft/kernel-memory/issues/934

High level description (Approach, Design)

using ElasticSearch Client .Size(limit) clause during query. using .Similarity(min score) to fix minRelevance (after adjusting the score value based on cosine similarity as per https://www.elastic.co/guide/en/elasticsearch/reference/current/knn-search.html#knn-similarity-search)

basyonic avatar Dec 10 '24 02:12 basyonic

@microsoft-github-policy-service agree

basyonic avatar Dec 12 '24 13:12 basyonic

Pausing this while we wait for SK Vector Store relase and integration.

dluc avatar Mar 22 '25 22:03 dluc

Closing as part of repository maintenance - no further action planned on this issue.

dluc avatar Nov 03 '25 18:11 dluc