iqsharp icon indicating copy to clipboard operation
iqsharp copied to clipboard

Update `GetEmbeddedKernelResources` to support proper directory structure

Open theRoughCode opened this issue 5 years ago • 3 comments

With this new PR merged into Jupyter Core, we can remove the "hack" in here to allow proper directory structure and naming with / once the next release rolls around for Jupyter Core and the version in this repo is updated.

theRoughCode avatar Jul 07 '20 14:07 theRoughCode

@theRoughCode releases of Jupyter Core are handled manually on an as-needed basis; there's no regular release cadence for that package. Let me know if you'd like more details on that, and I'd be happy to help get a new release pushed.

rmshaffer avatar Jul 14 '20 14:07 rmshaffer

Sounds good! I guess the change doesn't impact any existing files, so we could wait for the next release (whenever that might be). Or if you think that it would be useful to include that change, we can do that and I can work on the fix. :)

theRoughCode avatar Jul 15 '20 20:07 theRoughCode

Makes sense! I think if this doesn't affect anything immediately then there's no need to do it right now. We can just leave this issue open as a reminder to do it after the next release of Jupyter Core.

rmshaffer avatar Jul 15 '20 20:07 rmshaffer