hyperspace
hyperspace copied to clipboard
Scaladoc consistency
Forked from #399. Maybe a super nit issue 😉
I'm okay with any options, but they should be applied consistently.
Identified inconsistencies during the review:
- Starting a description for a
@paramor@returnwith uppercase or lowercase - Putting a period after a description for a
@paramor@return - Duplicating Scaladoc comments for overriding methods
Here're my thoughts:
- Either uppercase or lowercase is fine. Since uppercase is more prevalent in our code, let's go with uppercase.
- Put a period after a proper sentence, or after a phrase if it is followed by another phrase or sentence. No period after a phrase if it ends the description.
- Don't duplicate if the content is identical and there is no new information. Duplicating a part of the content with new information for the specific implementation is allowed.
Thanks for initiating this issue! I'm good with those suggestions. :)
I'm good with it. One step further is to implement the rules above in scalafmt checker but I don't know if that is possible.
I'm good with it. One step further is to implement the rules above in
scalafmtchecker but I don't know if that is possible.
It seems you can't, although you can specify the overall look and style of the Scaladoc comments.