graphrag icon indicating copy to clipboard operation
graphrag copied to clipboard

Move embeddings target position

Open longyunfeigu opened this issue 1 year ago • 1 comments

Description

embeddings target is the same level as llm, and the way it is written now will confuse users who haven't read the source code with target as the next level of llm, so changing the target doesn't take effect.

Related Issues

[Reference any related issues or tasks that this pull request addresses.]

Proposed Changes

[List the specific changes made in this pull request.]

Checklist

  • [ ] I have tested these changes locally.
  • [ ] I have reviewed the code changes.
  • [ ] I have updated the documentation (if necessary).
  • [ ] I have added appropriate unit tests (if applicable).

Additional Notes

[Add any additional notes or context that may be helpful for the reviewer(s).]

longyunfeigu avatar Aug 15 '24 06:08 longyunfeigu

@microsoft-github-policy-service agree

longyunfeigu avatar Aug 15 '24 06:08 longyunfeigu