graphrag icon indicating copy to clipboard operation
graphrag copied to clipboard

Add source URL to the package

Open gukoff opened this issue 1 year ago • 2 comments

Description

Add a link to the source on the pypi page.

Checklist

  • [ ] I have tested these changes locally.
  • [x] I have reviewed the code changes.
  • [x] I have updated the documentation (if necessary).
  • [x] I have added appropriate unit tests (if applicable).

gukoff avatar Aug 14 '24 09:08 gukoff

Hi @gukoff, thanks for your contribution. It appears that specifying the Source url may have some negative consequences for some people (those with private PyPI’s or behind corporate networks).

I’m inclined to not approve this change until I’ve learned more about the impact of this change.

jgbradley1 avatar Aug 22 '24 12:08 jgbradley1

tool.poetry.source is a different poetry config value, you're looking for tool.poetry.urls :)

Here the "Source" is a free-form string, you can as well write "Source code".

It's to define the project links displayed on the PyPI page:

Screenshot 2024-08-22 at 16 17 04

gukoff avatar Aug 22 '24 14:08 gukoff