graphrag icon indicating copy to clipboard operation
graphrag copied to clipboard

[Fix bug] Better for local embedding models

Open lyyf2002 opened this issue 1 year ago • 4 comments

Description

This pull request adds functionality to decode chunks back to strings, enabling the use of local embedding models that only accept string inputs.

Related Issues

https://github.com/microsoft/graphrag/issues/451 https://github.com/microsoft/graphrag/issues/528

Proposed Changes

  • Decodes the encoded chunks back to strings.
  • Integrates the local embedding models with the decoded strings.

Checklist

  • [x] I have tested these changes locally.
  • [x] I have reviewed the code changes.
  • [ ] I have updated the documentation (if necessary).
  • [ ] I have added appropriate unit tests (if applicable).

Additional Notes

These changes ensure compatibility with local embedding models that require string inputs, enhancing the overall functionality and flexibility of the system.

lyyf2002 avatar Jul 15 '24 12:07 lyyf2002

This wonderfully resolves the weight summed to zero issues. Thanks for the PR. Hope the MS team could merge this soon.

davidliudev avatar Jul 25 '24 03:07 davidliudev

This pr is perfectly resolve error in local query,thank you very much. Hope this pr can be merge soon.

cedarwud avatar Aug 01 '24 08:08 cedarwud

This wonderfully resolves the weight summed to zero issues. Thanks for the PR. Hope the MS team could merge this soon.

bytewei avatar Aug 07 '24 15:08 bytewei

Hi @lyyf2002

Thanks for your contribution! On 0.2.2 we merged a change that should have fixed this. Could you please try with the latest version (0.3.1)?

AlonsoGuevara avatar Aug 22 '24 16:08 AlonsoGuevara