graphitation icon indicating copy to clipboard operation
graphitation copied to clipboard

HOTFIX: fix subscription narrowing problem

Open vejrj opened this issue 1 year ago • 4 comments

vejrj avatar May 11 '23 08:05 vejrj

I’m missing an example of what the resolver implementation would look like. Is this requiring folks to include the kind property in their implementation?

Yes, you will need to add kind for "SubscribeAndResolve"

vejrj avatar May 11 '23 09:05 vejrj

That doesn’t seem helpful. At that point it’s more intuitive to export two different type definitions.

alloy avatar May 11 '23 09:05 alloy

That doesn’t seem helpful. At that point it’s more intuitive to export two different type definitions.

That was my initial idea, but @freiksenet said that we would need to refactor everything then.

vejrj avatar May 11 '23 09:05 vejrj

Can you elaborate on the difference in effort needed to add kind vs using a different type? Both can be done relatively the same way with a codemod afaik.

alloy avatar May 11 '23 09:05 alloy