glTF-SDK icon indicating copy to clipboard operation
glTF-SDK copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Better support build on *NIX platforms

Open orzel7 opened this issue 2 years ago • 6 comments

I'm trying to using library on Linux. This is very basic support, but in the future i am going to implement advanced things.

orzel7 avatar Sep 27 '21 15:09 orzel7

CLA assistant check
All CLA requirements met.

ghost avatar Sep 27 '21 15:09 ghost

Sorry @orzel7. We missed this PR somehow. I think it would be great if we can get some CI for linux before merging or this will break again.

bghgary avatar Oct 28 '21 16:10 bghgary

this PR is great, any timeframe for getting this merged?

joaquin4d avatar Dec 16 '21 12:12 joaquin4d

We can merge, but with a CI being added, it may break easily. Anyone want to take a stab at adding Linux CI?

bghgary avatar Dec 16 '21 18:12 bghgary

Don't see any docs explaining what you mean, so I ask. Do you mean:

  • adding tests for linux? (but seems to me tests described in CMakeLists.txt don't exclude Linux platform)
  • adding github actions for Linux? (but currently there are none anyway for any platform)
  • adding a test specifically for testing if it builds on Linux? (but shouldn't this be just the act of compiling it on Linux?)

joaquin4d avatar Dec 16 '21 19:12 joaquin4d

We use Azure DevOps to do CI. It should be mostly just changing this file: https://github.com/microsoft/glTF-SDK/blob/master/Build/AzureDevOps/azure-pipelines.yml

bghgary avatar Dec 16 '21 22:12 bghgary