generative-ai-for-beginners
generative-ai-for-beginners copied to clipboard
chapter15: bugfixes and improvements for notebook-rag-vector-databases.ipynb
Describe the bug depending on @koreyspace feedback, this issue might be split into several issues.
there are a few problems in notebook-rag-vector-databases.ipynb I have already prepared a PR and fixes for the issues below
-
!pip install should be %pip install
-
pip install azure-cosmos is missing the %
-
az cosmosdb create statement uses a wrong option -r. This should be -g
-
az cosmosedb list-keys is deprecated. This should be replaced with "keys list" option
-
all envrionment variables should be replaced with an .env file and code which reads them (based on dotenv)
-
data file names are invalid (data/frameworks.md?WT.mc_id=academic-105485-koreyst). The part after ? shall be deleted
-
code to append() the DataFrame is outdated and shall be updated to use concat() etc
-
Python notebook could be split in two parts -- part one: read training data, and create embeddings -- part two: the RAG part
To Reproduce Steps to reproduce the behavior:
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Expected behavior A clear and concise description of what you expected to happen.
Screenshots If applicable, add screenshots to help explain your problem.
Additional context Add any other context about the problem here.