generative-ai-for-beginners icon indicating copy to clipboard operation
generative-ai-for-beginners copied to clipboard

.gitignore should ignore downloaded files of sample 08-building-search-applications

Open merklbe1SICKAG opened this issue 1 year ago • 1 comments

Describe the bug in sample 08-building-search-applications the script (transcript_download.py) downloads data from youtube and stores is in subdirectory within the sample. However this is data which does not belong to the version control, hence there should be an entry in .gitignore.

To Reproduce Steps to reproduce the behavior:

  1. Go to 08-building-search-applications
  2. build the example, download dependencies with pip etc
  3. start the example via the prepare_transcripts_ai_show.sh
  4. this downloads file to 08-building-search-applications/scripts/transcripts_the_ai_show/
  5. git shows the downloaded files as U, however they should be ignored

Expected behavior downloaded files should be ignored in git.

merklbe1SICKAG avatar Jul 26 '24 14:07 merklbe1SICKAG

👋 Thanks for contributing @merklbe1SICKAG! We will review the issue and get back to you soon.

github-actions[bot] avatar Jul 26 '24 14:07 github-actions[bot]

Thanks for reporting and the PR. I have tagged @gloveboxes to review as the lesson owner.

koreyspace avatar Jul 28 '24 12:07 koreyspace