garnet icon indicating copy to clipboard operation
garnet copied to clipboard

Was the unused code left by design, or was it perhaps an oversight?

Open InCerryGit opened this issue 1 year ago • 0 comments

I've noticed that there are some codes or variables that haven't been used. Is this by design, or might it have been an oversight?

The objectLogDevice

https://github.com/microsoft/garnet/blob/9ca34a25dfd71eedcc4e955254694fc17941cc3e/libs/storage/Tsavorite/cs/src/core/Allocator/SpanByteAllocator.cs#L414

The newCurrentAddress

https://github.com/microsoft/garnet/blob/9ca34a25dfd71eedcc4e955254694fc17941cc3e/libs/storage/Tsavorite/cs/src/core/TsavoriteLog/TsavoriteLogIterator.cs#L497

InCerryGit avatar Mar 22 '24 13:03 InCerryGit