garnet icon indicating copy to clipboard operation
garnet copied to clipboard

Support the configuration API for generic configuration providers

Open Meir017 opened this issue 1 year ago • 2 comments

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Currently, when running the garnet server we must provider either command-line arguments or a garnet.conf JSON file. By adopting the https://learn.microsoft.com/en-us/dotnet/core/extensions/configuration we will be able to use any configuration provider and require less manual work for maintaining the Options file

Describe the solution you'd like

building on top of #579 we would call builder.Configuration.AddEnvironmentVariables(prefix: "GARNET_") (see https://learn.microsoft.com/en-us/dotnet/core/extensions/configuration-providers#prefixes)

Describe alternatives you've considered

No response

Additional context

No response

Meir017 avatar Aug 26 '24 06:08 Meir017

This is a valid suggestion, but we were not able to do it in a way that ensure backwards compatibility with the switches. So went with garnet.conf.

badrishc avatar Aug 26 '24 09:08 badrishc

the Command-line configuration provider https://learn.microsoft.com/en-us/dotnet/core/extensions/configuration-providers#command-line-configuration-provider almost matches the command-line arguments that exist today.

I think the command-line arguments can wait (still use the Options class) but adding support for environment-variables won't interfere with the current configuration

Meir017 avatar Aug 26 '24 13:08 Meir017