garnet icon indicating copy to clipboard operation
garnet copied to clipboard

Use generic host for GarnetServer

Open Meir017 opened this issue 1 year ago • 1 comments

Feature request type

enhancement

Is your feature request related to a problem? Please describe

Using the generic host https://learn.microsoft.com/en-us/aspnet/core/fundamentals/host/generic-host will simplify how we bootstrap the server

Describe the solution you'd like

wire up using DI the dependencies that are created manually.

Describe alternatives you've considered

No response

Additional context

see the manual configuration https://github.com/microsoft/garnet/blob/main/libs/host/GarnetServer.cs#L151C13-L210C57

Meir017 avatar Aug 09 '24 15:08 Meir017

#394 starts doing this,

I think we can take that PR without the windows service code as I think it's still in discussion

Meir017 avatar Aug 12 '24 17:08 Meir017

Mostly addressed by https://github.com/microsoft/garnet/pull/614 - feel free to create PR if you have more ideas in this space.

badrishc avatar Sep 12 '24 01:09 badrishc