garnet icon indicating copy to clipboard operation
garnet copied to clipboard

API Coverage - Implement HELLO

Open mattholy opened this issue 9 months ago • 0 comments

Feature request type

sample request

Is your feature request related to a problem? Please describe

When using example from https://microsoft.github.io/garnet/docs/welcome/releases

redis-cli
127.0.0.1:6379> set key value
OK
127.0.0.1:6379> get key
"value"
127.0.0.1:6379> hello
(error) ERR unknown command

But for a actual redis:

127.0.0.1:6379> hello
[
    "server",
    "redis",
    "version",
    "7.2.4",
    "proto",
    2,
    "id",
    8,
    "mode",
    "standalone",
    "role",
    "master",
    "modules",
    []
]

It matters because some python frameworks like Celery are using hello. It's a pity if they can not use such a k-v database.

Describe the solution you'd like

Implement https://redis.io/docs/latest/commands/hello/

Describe alternatives you've considered

No response

Additional context

https://github.com/celery/celery/blob/90ff2e1290ef058e8dc59dc1d86ff38f668abc50/celery/app/control.py#L388-L389

mattholy avatar Apr 30 '24 14:04 mattholy