frontend-bootcamp icon indicating copy to clipboard operation
frontend-bootcamp copied to clipboard

Please make your examples accessible

Open 7mary4 opened this issue 6 years ago • 2 comments

This is a great course and people will use your examples as a best practice. Please ensure your examples are accessible. For instance, the first exercise has an input that depends on the placeholder attribute instead of a label. <input class="textfield" placeholder="add todo">

Providing accessible examples will ensure the next generation of developers include it in their work.

7mary4 avatar Mar 01 '19 17:03 7mary4

How do you feel this is not accessible? Narrator has no trouble reading the placeholder text. Adding aria-label would be redundant.

micahgodbolt avatar Mar 04 '19 05:03 micahgodbolt

@micahgodbolt placeholer are technicaly correct but for real life example they are not the best. https://www.smashingmagazine.com/2018/06/placeholder-attribute/

I think @7mary4 wanted to add the classic label + input combo.

flexbox avatar Mar 04 '19 08:03 flexbox