fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

update message bar to use semantic tokens

Open rachethecreator opened this issue 5 months ago • 1 comments

Update to semantic tokens where applicable for react-message-bar Add fallback values to fluentOverrides

Gaps noted here

Kumo implementation here

Figma design here

Previous Behavior

Used fluentui/tokens

New Behavior

Used fluentui/semantic-tokens if a replacement exists

rachethecreator avatar Jun 16 '25 16:06 rachethecreator

Pull request demo site: URL

github-actions[bot] avatar Jun 16 '25 17:06 github-actions[bot]

Looks good, just one small visual regression

Let's investigate why the button boldness is different between current prod and semantic styles: image image

Mitch-At-Work avatar Jun 27 '25 20:06 Mitch-At-Work

Looks good, just one small visual regression

Let's investigate why the button boldness is different between current prod and semantic styles: image image

Looks like it's directly due to the Button component. The small size should have regular font weight, but is mapped to have semibold, like the medium and large sizes. Fixed this in the following commit in Button.

rachethecreator avatar Jul 01 '25 19:07 rachethecreator