fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Obsolete `createPresenceComponentVariant` and `overridePresenceMotion` once they are no longer used

Open robertpenner opened this issue 1 year ago • 3 comments

NOTE: not needed for beta

Since we found a simpler way to define motion component variants, we will not be using createPresenceComponentVariant nor its helper function overridePresenceMotion, once we have migrated:

  • [x] Collapse
  • [x] Fade
  • [ ] Scale - 33112

For Discussion

  • "Obsolete" can mean either deleting, or deprecating.
  • While createPresenceComponentVariant was exposed as an export from @fluentui/react-motion, it was never used or documented in that stable package. It was only documented in the preview package react-motion-components-preview.
  • So the question is: do we have to treat this deletion as a breaking change?

robertpenner avatar Oct 22 '24 21:10 robertpenner

So the question is: do we have to treat this deletion as a breaking change?

Yes, it's BC. Removal anything/changing the contract of anything coming from packages that don't have -preview suffix - is a breaking change. So, it can be only deprecated.

layershifter avatar Oct 23 '24 15:10 layershifter

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. Still require assistance? Please add comment - "keep open".

bot keep open

layershifter avatar Jun 16 '25 08:06 layershifter