fluentui icon indicating copy to clipboard operation
fluentui copied to clipboard

Standardize positioning attribute values to use `start` and `end` vs `after` and `before`

Open eljefe223 opened this issue 1 year ago • 1 comments

Environment Information

  • Package version(s): (fill this out)
  • Browser and OS versions: (fill this out if relevant)

Describe the issue:

For controls that have positioning attributes, ie LabelPosition or IconPosition we are inconstant in the language we use to describe where an element will layout. In some cases, we use start and end and in others we use before and after. We should standardize on start and end which is more consistent with CSS and localization properties and values like flex-start or margin-inline-start

Before and After https://react.fluentui.dev/?path=/docs/components-switch--docs#label

Start and End https://react.fluentui.dev/?path=/docs/components-accordion--docs#expand-icon-position

Actual behavior:

We are not consistent with language used.

Expected behavior:

BE consistent with language used.

If applicable, please provide a codepen repro:

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: (Blocking, High, Normal, Low)

Products/sites affected: (if applicable)

eljefe223 avatar Aug 19 '24 22:08 eljefe223

This valid as our positioning prop values do contain inconsistencies (see below). Fixing these to be consistent across the board in v9 would be a breaking change but this is possibly a good RFC candidate for a naming pattern to follow for new components and beyond (v10 etc.).

TS Badge types ts packagesreact-componentsreact-b AccordionHeaderExpandiconPosition = 'start'  'end';

TristanWatanabe avatar Aug 22 '24 14:08 TristanWatanabe

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. Still require assistance? Please add comment - "keep open".

keep open

ValentinaKozlova avatar Mar 03 '25 09:03 ValentinaKozlova

This issue has not had activity for over 180 days! We're adding Soft close label and will close it soon for house-keeping purposes. Still require assistance? Please add comment - "keep open".