fluentui
fluentui copied to clipboard
chore(react-text): enable nx dependency-checks lint rule in order to replace eslint-import-plugin
Pre-requirement
- [ ] enabling nx source analyzer https://github.com/microsoft/fluentui/pull/32359
Previous Behavior
New Behavior
Related Issue(s)
- Fixes https://github.com/microsoft/fluentui/issues/27727
📊 Bundle size report
✅ No changes found
Perf Analysis (@fluentui/react-components)
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Button | mount | 300 | 302 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 617 | 618 | 5000 | |
| Button | mount | 300 | 302 | 5000 | Possible regression |
| Field | mount | 1146 | 1149 | 5000 | |
| FluentProvider | mount | 692 | 702 | 5000 | |
| FluentProviderWithTheme | mount | 91 | 81 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 38 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 81 | 10 | |
| MakeStyles | mount | 854 | 846 | 50000 | |
| Persona | mount | 1726 | 1746 | 5000 | |
| SpinButton | mount | 1390 | 1395 | 5000 | |
| SwatchPicker | mount | 1617 | 1632 | 5000 |
🕵 FluentUIV0 No visual regressions between this PR and main
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 128 | 102 | 1.25:1 |
| SkeletonMinimalPerf.default | 216 | 189 | 1.14:1 |
| AttachmentMinimalPerf.default | 85 | 76 | 1.12:1 |
| ButtonMinimalPerf.default | 96 | 86 | 1.12:1 |
| HeaderMinimalPerf.default | 223 | 202 | 1.1:1 |
| BoxMinimalPerf.default | 210 | 195 | 1.08:1 |
| LayoutMinimalPerf.default | 215 | 200 | 1.08:1 |
| RadioGroupMinimalPerf.default | 273 | 254 | 1.07:1 |
| SegmentMinimalPerf.default | 207 | 193 | 1.07:1 |
| FlexMinimalPerf.default | 154 | 145 | 1.06:1 |
| PortalMinimalPerf.default | 91 | 86 | 1.06:1 |
| TextMinimalPerf.default | 202 | 190 | 1.06:1 |
| CarouselMinimalPerf.default | 270 | 257 | 1.05:1 |
| ChatWithPopoverPerf.default | 206 | 196 | 1.05:1 |
| TableMinimalPerf.default | 246 | 235 | 1.05:1 |
| AccordionMinimalPerf.default | 93 | 89 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 157 | 151 | 1.04:1 |
| EmbedMinimalPerf.default | 1942 | 1875 | 1.04:1 |
| GridMinimalPerf.default | 197 | 189 | 1.04:1 |
| ImageMinimalPerf.default | 234 | 225 | 1.04:1 |
| ListWith60ListItems.default | 384 | 368 | 1.04:1 |
| TableManyItemsPerf.default | 1160 | 1114 | 1.04:1 |
| VideoMinimalPerf.default | 445 | 428 | 1.04:1 |
| ButtonSlotsPerf.default | 322 | 314 | 1.03:1 |
| HeaderSlotsPerf.default | 480 | 467 | 1.03:1 |
| InputMinimalPerf.default | 558 | 544 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 720 | 701 | 1.03:1 |
| LoaderMinimalPerf.default | 194 | 188 | 1.03:1 |
| StatusMinimalPerf.default | 405 | 393 | 1.03:1 |
| AnimationMinimalPerf.default | 303 | 297 | 1.02:1 |
| CheckboxMinimalPerf.default | 1166 | 1139 | 1.02:1 |
| DialogMinimalPerf.default | 451 | 444 | 1.02:1 |
| DropdownMinimalPerf.default | 1472 | 1443 | 1.02:1 |
| LabelMinimalPerf.default | 230 | 226 | 1.02:1 |
| MenuButtonMinimalPerf.default | 975 | 957 | 1.02:1 |
| ProviderMergeThemesPerf.default | 655 | 645 | 1.02:1 |
| RefMinimalPerf.default | 113 | 111 | 1.02:1 |
| SliderMinimalPerf.default | 758 | 746 | 1.02:1 |
| FormMinimalPerf.default | 229 | 226 | 1.01:1 |
| ListNestedPerf.default | 331 | 328 | 1.01:1 |
| PopupMinimalPerf.default | 353 | 349 | 1.01:1 |
| ReactionMinimalPerf.default | 213 | 211 | 1.01:1 |
| CustomToolbarPrototype.default | 1499 | 1481 | 1.01:1 |
| ToolbarMinimalPerf.default | 548 | 543 | 1.01:1 |
| TreeMinimalPerf.default | 486 | 480 | 1.01:1 |
| CardMinimalPerf.default | 310 | 310 | 1:1 |
| DividerMinimalPerf.default | 215 | 214 | 1:1 |
| ListCommonPerf.default | 399 | 399 | 1:1 |
| RosterPerf.default | 1570 | 1575 | 1:1 |
| ProviderMinimalPerf.default | 209 | 209 | 1:1 |
| DropdownManyItemsPerf.default | 399 | 404 | 0.99:1 |
| MenuMinimalPerf.default | 508 | 514 | 0.99:1 |
| TextAreaMinimalPerf.default | 294 | 297 | 0.99:1 |
| TreeWith60ListItems.default | 85 | 86 | 0.99:1 |
| AttachmentSlotsPerf.default | 636 | 647 | 0.98:1 |
| ButtonOverridesMissPerf.default | 652 | 665 | 0.98:1 |
| TooltipMinimalPerf.default | 1265 | 1292 | 0.98:1 |
| ListMinimalPerf.default | 306 | 316 | 0.97:1 |
| ChatMinimalPerf.default | 434 | 452 | 0.96:1 |
| SplitButtonMinimalPerf.default | 2223 | 2309 | 0.96:1 |
| IconMinimalPerf.default | 393 | 413 | 0.95:1 |
| DatepickerMinimalPerf.default | 3650 | 3905 | 0.93:1 |
| AlertMinimalPerf.default | 150 | 166 | 0.9:1 |
Perf Analysis (@fluentui/react)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 629 | 626 | 5000 | |
| Breadcrumb | mount | 1683 | 1694 | 1000 | |
| Checkbox | mount | 1686 | 1695 | 5000 | |
| CheckboxBase | mount | 1504 | 1479 | 5000 | |
| ChoiceGroup | mount | 2975 | 2925 | 5000 | |
| ComboBox | mount | 697 | 709 | 1000 | |
| CommandBar | mount | 6518 | 6547 | 1000 | |
| ContextualMenu | mount | 12500 | 12621 | 1000 | |
| DefaultButton | mount | 778 | 778 | 5000 | |
| DetailsRow | mount | 2243 | 2270 | 5000 | |
| DetailsRowFast | mount | 2251 | 2227 | 5000 | |
| DetailsRowNoStyles | mount | 2072 | 2067 | 5000 | |
| Dialog | mount | 2705 | 2886 | 1000 | |
| DocumentCardTitle | mount | 232 | 236 | 1000 | |
| Dropdown | mount | 2030 | 1989 | 5000 | |
| FocusTrapZone | mount | 1206 | 1159 | 5000 | |
| FocusZone | mount | 1092 | 1124 | 5000 | |
| GroupedList | mount | 42135 | 42404 | 2 | |
| GroupedList | virtual-rerender | 20391 | 20254 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51646 | 51708 | 2 | |
| GroupedListV2 | mount | 228 | 232 | 2 | |
| GroupedListV2 | virtual-rerender | 217 | 213 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 234 | 250 | 2 | |
| IconButton | mount | 1107 | 1188 | 5000 | |
| Label | mount | 335 | 342 | 5000 | |
| Layer | mount | 2753 | 2710 | 5000 | |
| Link | mount | 391 | 398 | 5000 | |
| MenuButton | mount | 974 | 994 | 5000 | |
| MessageBar | mount | 21426 | 21375 | 5000 | |
| Nav | mount | 2074 | 2079 | 1000 | |
| OverflowSet | mount | 795 | 792 | 5000 | |
| Panel | mount | 1895 | 1834 | 1000 | |
| Persona | mount | 760 | 759 | 1000 | |
| Pivot | mount | 939 | 919 | 1000 | |
| PrimaryButton | mount | 927 | 919 | 5000 | |
| Rating | mount | 4765 | 4752 | 5000 | |
| SearchBox | mount | 913 | 953 | 5000 | |
| Shimmer | mount | 1941 | 1916 | 5000 | |
| Slider | mount | 1364 | 1385 | 5000 | |
| SpinButton | mount | 3042 | 3010 | 5000 | |
| Spinner | mount | 389 | 406 | 5000 | |
| SplitButton | mount | 1909 | 1916 | 5000 | |
| Stack | mount | 421 | 429 | 5000 | |
| StackWithIntrinsicChildren | mount | 873 | 891 | 5000 | |
| StackWithTextChildren | mount | 2758 | 2788 | 5000 | |
| SwatchColorPicker | mount | 6496 | 6470 | 5000 | |
| TagPicker | mount | 1468 | 1468 | 5000 | |
| Text | mount | 386 | 385 | 5000 | |
| TextField | mount | 944 | 963 | 5000 | |
| ThemeProvider | mount | 858 | 873 | 5000 | |
| ThemeProvider | virtual-rerender | 613 | 571 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1297 | 1301 | 5000 | |
| Toggle | mount | 613 | 630 | 5000 | |
| buttonNative | mount | 200 | 203 | 5000 |
/azp run
Azure Pipelines successfully started running 4 pipeline(s).