fluentui
fluentui copied to clipboard
chore: migrate to nx 19.2.3
Previous Behavior
New Behavior
- see PR title
- bumps swc loader and de-indent plugin (https://github.com/microsoft/fluentui/issues/30718) in order to support bumped swc/core version
Related Issue(s)
- Follows https://github.com/microsoft/fluentui/pull/31827
📊 Bundle size report
✅ No changes found
Perf Analysis (@fluentui/react-northstar)
:warning: 1 potential perf regressions detected
Potential regressions comparing to master
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| InputMinimalPerf.default | 533 | 523 | 1.02:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 96 | 80 | 1.2:1 |
| AccordionMinimalPerf.default | 93 | 78 | 1.19:1 |
| BoxMinimalPerf.default | 214 | 189 | 1.13:1 |
| AttachmentMinimalPerf.default | 87 | 78 | 1.12:1 |
| DividerMinimalPerf.default | 219 | 198 | 1.11:1 |
| VideoMinimalPerf.default | 460 | 423 | 1.09:1 |
| CardMinimalPerf.default | 329 | 305 | 1.08:1 |
| FormMinimalPerf.default | 231 | 214 | 1.08:1 |
| ButtonMinimalPerf.default | 93 | 88 | 1.06:1 |
| LoaderMinimalPerf.default | 198 | 186 | 1.06:1 |
| PortalMinimalPerf.default | 88 | 84 | 1.05:1 |
| CheckboxMinimalPerf.default | 1156 | 1116 | 1.04:1 |
| GridMinimalPerf.default | 197 | 189 | 1.04:1 |
| ListMinimalPerf.default | 319 | 306 | 1.04:1 |
| RefMinimalPerf.default | 115 | 111 | 1.04:1 |
| AttachmentSlotsPerf.default | 635 | 616 | 1.03:1 |
| ButtonOverridesMissPerf.default | 655 | 638 | 1.03:1 |
| DialogMinimalPerf.default | 446 | 434 | 1.03:1 |
| EmbedMinimalPerf.default | 1883 | 1836 | 1.03:1 |
| HeaderMinimalPerf.default | 212 | 206 | 1.03:1 |
| LayoutMinimalPerf.default | 212 | 205 | 1.03:1 |
| ListNestedPerf.default | 328 | 319 | 1.03:1 |
| ListWith60ListItems.default | 376 | 366 | 1.03:1 |
| RosterPerf.default | 1619 | 1570 | 1.03:1 |
| TableManyItemsPerf.default | 1123 | 1089 | 1.03:1 |
| DropdownManyItemsPerf.default | 396 | 389 | 1.02:1 |
| DropdownMinimalPerf.default | 1449 | 1421 | 1.02:1 |
| MenuMinimalPerf.default | 514 | 504 | 1.02:1 |
| SegmentMinimalPerf.default | 201 | 198 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2310 | 2272 | 1.02:1 |
| IconMinimalPerf.default | 391 | 384 | 1.02:1 |
| TableMinimalPerf.default | 242 | 237 | 1.02:1 |
| TreeMinimalPerf.default | 488 | 477 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 154 | 152 | 1.01:1 |
| HeaderSlotsPerf.default | 463 | 457 | 1.01:1 |
| ImageMinimalPerf.default | 224 | 222 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 706 | 701 | 1.01:1 |
| LabelMinimalPerf.default | 225 | 222 | 1.01:1 |
| ProviderMergeThemesPerf.default | 653 | 647 | 1.01:1 |
| SkeletonMinimalPerf.default | 198 | 196 | 1.01:1 |
| StatusMinimalPerf.default | 401 | 399 | 1.01:1 |
| CustomToolbarPrototype.default | 1476 | 1462 | 1.01:1 |
| ButtonSlotsPerf.default | 322 | 322 | 1:1 |
| ChatWithPopoverPerf.default | 192 | 192 | 1:1 |
| MenuButtonMinimalPerf.default | 953 | 956 | 1:1 |
| RadioGroupMinimalPerf.default | 262 | 263 | 1:1 |
| ReactionMinimalPerf.default | 218 | 219 | 1:1 |
| ToolbarMinimalPerf.default | 546 | 545 | 1:1 |
| ListCommonPerf.default | 380 | 384 | 0.99:1 |
| PopupMinimalPerf.default | 348 | 352 | 0.99:1 |
| ProviderMinimalPerf.default | 196 | 198 | 0.99:1 |
| TooltipMinimalPerf.default | 1250 | 1257 | 0.99:1 |
| AlertMinimalPerf.default | 157 | 161 | 0.98:1 |
| AvatarMinimalPerf.default | 112 | 114 | 0.98:1 |
| DatepickerMinimalPerf.default | 3531 | 3601 | 0.98:1 |
| SliderMinimalPerf.default | 716 | 732 | 0.98:1 |
| TextMinimalPerf.default | 191 | 194 | 0.98:1 |
| ChatMinimalPerf.default | 430 | 444 | 0.97:1 |
| CarouselMinimalPerf.default | 256 | 269 | 0.95:1 |
| TextAreaMinimalPerf.default | 274 | 289 | 0.95:1 |
| AnimationMinimalPerf.default | 277 | 296 | 0.94:1 |
| FlexMinimalPerf.default | 151 | 162 | 0.93:1 |
🕵 FluentUIV0 No visual regressions between this PR and main
Perf Analysis (@fluentui/react)
No significant results to display.
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 636 | 645 | 5000 | |
| Breadcrumb | mount | 1781 | 1807 | 1000 | |
| Checkbox | mount | 1712 | 1736 | 5000 | |
| CheckboxBase | mount | 1497 | 1491 | 5000 | |
| ChoiceGroup | mount | 3036 | 2999 | 5000 | |
| ComboBox | mount | 714 | 686 | 1000 | |
| CommandBar | mount | 6935 | 7081 | 1000 | |
| ContextualMenu | mount | 17398 | 17356 | 1000 | |
| DefaultButton | mount | 781 | 818 | 5000 | |
| DetailsRow | mount | 2246 | 2264 | 5000 | |
| DetailsRowFast | mount | 2263 | 2258 | 5000 | |
| DetailsRowNoStyles | mount | 2032 | 2075 | 5000 | |
| Dialog | mount | 2740 | 2768 | 1000 | |
| DocumentCardTitle | mount | 225 | 227 | 1000 | |
| Dropdown | mount | 2000 | 2000 | 5000 | |
| FocusTrapZone | mount | 1170 | 1157 | 5000 | |
| FocusZone | mount | 1080 | 1101 | 5000 | |
| GroupedList | mount | 42999 | 43184 | 2 | |
| GroupedList | virtual-rerender | 18403 | 20871 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 54073 | 53852 | 2 | |
| GroupedListV2 | mount | 236 | 236 | 2 | |
| GroupedListV2 | virtual-rerender | 223 | 226 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 241 | 241 | 2 | |
| IconButton | mount | 1143 | 1188 | 5000 | |
| Label | mount | 354 | 356 | 5000 | |
| Layer | mount | 2764 | 2775 | 5000 | |
| Link | mount | 399 | 415 | 5000 | |
| MenuButton | mount | 1007 | 994 | 5000 | |
| MessageBar | mount | 22482 | 22340 | 5000 | |
| Nav | mount | 2071 | 2072 | 1000 | |
| OverflowSet | mount | 809 | 781 | 5000 | |
| Panel | mount | 1871 | 1848 | 1000 | |
| Persona | mount | 756 | 772 | 1000 | |
| Pivot | mount | 933 | 918 | 1000 | |
| PrimaryButton | mount | 930 | 959 | 5000 | |
| Rating | mount | 4672 | 4681 | 5000 | |
| SearchBox | mount | 926 | 921 | 5000 | |
| Shimmer | mount | 1909 | 1918 | 5000 | |
| Slider | mount | 1368 | 1374 | 5000 | |
| SpinButton | mount | 2970 | 2983 | 5000 | |
| Spinner | mount | 403 | 411 | 5000 | |
| SplitButton | mount | 1867 | 1870 | 5000 | |
| Stack | mount | 433 | 426 | 5000 | |
| StackWithIntrinsicChildren | mount | 889 | 882 | 5000 | |
| StackWithTextChildren | mount | 2790 | 2740 | 5000 | |
| SwatchColorPicker | mount | 6391 | 6461 | 5000 | |
| TagPicker | mount | 1469 | 1447 | 5000 | |
| Text | mount | 402 | 396 | 5000 | |
| TextField | mount | 989 | 953 | 5000 | |
| ThemeProvider | mount | 882 | 873 | 5000 | |
| ThemeProvider | virtual-rerender | 602 | 581 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1315 | 1329 | 5000 | |
| Toggle | mount | 628 | 615 | 5000 | |
| buttonNative | mount | 192 | 198 | 5000 |
Perf Analysis (@fluentui/react-components)
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 73 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 640 | 636 | 5000 | |
| Button | mount | 312 | 306 | 5000 | |
| Field | mount | 1126 | 1135 | 5000 | |
| FluentProvider | mount | 708 | 702 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 38 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 73 | 10 | Possible regression |
| MakeStyles | mount | 866 | 863 | 50000 | |
| Persona | mount | 1785 | 1688 | 5000 | |
| SpinButton | mount | 1419 | 1396 | 5000 | |
| SwatchPicker | mount | 1642 | 1665 | 5000 |